Fix repeated calls to Table.convert()
#526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonw
reviewed
May 8, 2023
| @@ -409,7 +414,7 @@ def register(fn): | |||
| fn_name = name or fn.__name__ | |||
| arity = len(inspect.signature(fn).parameters) | |||
| if not replace and (fn_name, arity) in self._registered_functions: | |||
| return fn | |||
| raise FunctionAlreadyRegistered(f'Already registered function with name "{fn_name}" and identical arity') | |||
There was a problem hiding this comment.
Just realized this represents a backward-incompatible change, so I'm going to back this out of the release.
simonw
added a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525. All tests pass.
There's perhaps a better way to name lambdas? There could be a collision if a caller passes a function with name like
lambda_123456.SQLite documentation is a little, ah, lite on function name specs. If there is a character that can be used in place of underscore in a SQLite function name that is not permitted in a Python function identifier then that could be a good way to prevent accidental collisions. (I tried dash, colon, dot, no joy).
Otherwise, there is little chance of this happening and if it should happen the risk is mitigated by now throwing an exception in the case of a (name, arity) collision without
replace=True.📚 Documentation preview 📚: https://sqlite-utils--526.org.readthedocs.build/en/526/