What should happen if you attempt to use strict=True against a SQLite version prior to 3.37.0?

An obvious error would be best... but how about silently ignoring it on older versions instead? That would match how we handle deterministic=True for registering functions:

sqlite-utils/sqlite_utils/db.py

Lines 372 to 380 in 1267037

    
           def register(fn): 
        
               name = fn.__name__ 
        
               arity = len(inspect.signature(fn).parameters) 
        
               if not replace and (name, arity) in self._registered_functions: 
        
                   return fn 
        
               kwargs = {} 
        
               if deterministic and sys.version_info >= (3, 8): 
        
                   kwargs["deterministic"] = True 
        
               self.conn.create_function(name, arity, fn, **kwargs)

sqlite-utils/tests/test_register_function.py

Lines 34 to 37 in 93c7fd9

    
           @pytest.mark.skipif( 
        
               sys.version_info < (3, 8), reason="deterministic=True was added in Python 3.8" 
        
           ) 
        
           def test_register_function_deterministic_registered(fresh_db):

	def register(fn):
	name = fn.__name__
	arity = len(inspect.signature(fn).parameters)
	if not replace and (name, arity) in self._registered_functions:
	return fn
	kwargs = {}
	if deterministic and sys.version_info >= (3, 8):
	kwargs["deterministic"] = True
	self.conn.create_function(name, arity, fn, **kwargs)

	@pytest.mark.skipif(
	sys.version_info < (3, 8), reason="deterministic=True was added in Python 3.8"
	)
	def test_register_function_deterministic_registered(fresh_db):

Uh oh!

Support STRICT tables #344

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions