Skip to content

Add support for --wait-for and --timeout to pdf command #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2025
Merged

Add support for --wait-for and --timeout to pdf command #161

merged 1 commit into from
Feb 13, 2025

Conversation

miccou
Copy link
Contributor

@miccou miccou commented Nov 19, 2024 •
edited by github-actions bot
Loading

This PR adds the arguments --wait-for and --timeout to the shot-scraper pdf command to enable more nuanced waiting when generating PDFs.

I just copied the implementation from the shot method.

📚 Documentation preview 📚: https://shot-scraper--161.org.readthedocs.build/en/161/

@miccou
Copy link
Contributor Author

miccou commented Dec 2, 2024

Hello @simonw, did you get a chance to review this PR?

jefftriplett
jefftriplett approved these changes Jan 13, 2025
View reviewed changes
Copy link

@jefftriplett jefftriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hits a few edge cases I have seen.

@simonw
Copy link
Owner

simonw commented Feb 13, 2025

Thanks for this.

@simonw simonw merged commit 9d9e945 into simonw:main Feb 13, 2025
2 checks passed
simonw added a commit that referenced this pull request Feb 13, 2025
@simonw
Release 1.6
0f7531d 
Refs #146, #160, #161, #164, #165, #166, #167, #169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jefftriplett jefftriplett jefftriplett approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miccou @simonw @jefftriplett