Skip to content

--fail-on-error overlaps with --fail #103

New issue
New issue
Closed
Closed
--fail-on-error overlaps with --fail#103
Labels
bugSomething isn't working
@simonw

Description

@simonw
simonw
opened on Jan 30, 2023

When I built --fail in #102 I missed that shot-scraper multi already has a similar option, --fail-on-error.

That option turns out to not do much though:

shot-scraper/shot_scraper/cli.py

Lines 352 to 357 in 378a27c

@click.option(
"--timeout",
type=int,
help="Wait this many milliseconds before failing",
)
@click.option("--fail-on-error", is_flag=True, help="Fail noisily on error")

shot-scraper/shot_scraper/cli.py

Lines 439 to 444 in 378a27c

except TimeoutError as e:
if fail_on_error:
raise click.ClickException(str(e))
else:
click.echo(str(e), err=True)
continue

That's the only place it actually has an impact: if a page times out and --fail-on-error is set then you get an error, otherwise it gets skipped.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions