Looking at how the code is currently structured we reuse a single browser context for all the shots, which means it may be easier to save everything to the same HAR file rather than doing one HAR file per item.

Lines 534 to 548 in 477572c

    
           with sync_playwright() as p: 
        
               context, browser_obj = _browser_context( 
        
                   p, 
        
                   auth, 
        
                   scale_factor=scale_factor, 
        
                   browser=browser, 
        
                   browser_args=browser_args, 
        
                   user_agent=user_agent, 
        
                   timeout=timeout, 
        
                   reduced_motion=reduced_motion, 
        
                   auth_username=auth_username, 
        
                   auth_password=auth_password, 
        
               ) 
        
               try: 
        
                   for shot in shots:

	with sync_playwright() as p:
	context, browser_obj = _browser_context(
	p,
	auth,
	scale_factor=scale_factor,
	browser=browser,
	browser_args=browser_args,
	user_agent=user_agent,
	timeout=timeout,
	reduced_motion=reduced_motion,
	auth_username=auth_username,
	auth_password=auth_password,
	)
	try:
	for shot in shots:

Uh oh!

shot-scraper multi support for recording HAR files #166

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions