Ryancheley patch 1 document updates #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! The place you updated in the README is actually intended as a copy of the output of I think this information would work better as a Markdown section in the README itself, similar to the "Using db-to-sqlite with PostgreSQL schemas" section. |
|
Doh! 🤦🏻♂️ I’ll make an update to move it to its own section 😄 |
|
@simonw I made the updates to the documentation to have the MSSQL section separate based on your recommendation to use the "Using db-to-sqlite with PostgreSQL schemas" section. |
|
I should have landed this a year ago! Thanks. |
simonw
added a commit
that referenced
this pull request
Feb 7, 2023
|
Thanks for getting this merged @simonw. Better late than never 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@simonw documentation update to include examples for MS SQL
There may be a better way to show it and explain how it should be done, but I'm at a loss. The connection string for MS SQL with SQL Alchemy are just messy.
I also added headers to the connection string examples to separate them out and make it more clear which example went with which type of SQL.