Skip to content

Add version number support with Versioneer #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2018
Merged

Add version number support with Versioneer #279

merged 3 commits into from
May 22, 2018

Conversation

rgieseke
Copy link
Contributor

I think that's all for getting Versioneer support, I've been happily using it in a couple of projects ...

In [2]: datasette.__version__
Out[2]: '0.22+3.g6e12445'

Repo:
https://github.com/warner/python-versioneer

Versioneer Licence:
Public Domain (CC0-1.0)

Closes #273

@rgieseke
Add version number support with Versioneer
6e12445 
Repo:
https://github.com/warner/python-versioneer

Versioneer Licence:
Public Domain (CC0-1.0)

Closes #273
@simonw
Copy link
Owner

simonw commented May 22, 2018

This is fantastic!

I think I prefer the aesthetics of just "0.22" for the version string if it's a tagged release with no additional changes - does that work?

I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:

datasette/datasette/version.py

Line 1 in 558d9d7

__version_info__ = (0, 22)

Presumably we can generate that from the versioneer string?

@rgieseke
Add __version_info__ derived from __version__
e3c2057 
This might be tuple of more than two values (major and minor
version) if commits have been made after a release.
@rgieseke
Copy link
Contributor Author

I think I prefer the aesthetics of just "0.22" for the version string if it's a tagged release with no additional changes - does that work?

Yes! That's the default versioneer behaviour.

I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:

Should work now, it can be a two (for a tagged version), three or four items tuple.

In [2]: datasette.__version__
Out[2]: '0.12+292.ga70c2a8.dirty'

In [3]: datasette.__version_info__
Out[3]: ('0', '12+292', 'ga70c2a8', 'dirty')

@rgieseke
Copy link
Contributor Author

Sorry, just realised you rely on version being a module ...

@rgieseke
Copy link
Contributor Author

Alright, that should work now -- let me know if you would prefer any different behaviour.

@simonw simonw merged commit 49f3177 into simonw:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgieseke @simonw