Skip to content

Facets improvements plus suggested facets #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
May 16, 2018
Merged

Facets improvements plus suggested facets #261

merged 23 commits into from
May 16, 2018

Conversation

simonw
Copy link
Owner

@simonw simonw commented May 16, 2018 •
edited
Loading

Refs #255

simonw added 23 commits May 14, 2018 17:43
@simonw
Facet "selected" key and toggle_url now toggles, refs #255
cf6e784
@simonw
Facet toggling now works for integer columns, refs #255
7e61a1f
@simonw
path_with_added_args now works with multiple existing args
2a365b6
@simonw
Initial implementation of suggested facets
ce84d76 
Causes tests to break at the moment
@simonw
Facets no longer consider null values
b163b41
@simonw
Never suggest a facet if it only results in on option
bc1bf5c
@simonw
_sort/_next links now use new path_with_replaced_args method
590890f
@simonw
Facet results now have "truncated" field
158e795 
 To indicate if there was more than 20 distinct values. Refs #255
@simonw
Removed un-used variable
89af6f0
@simonw
Facets can now be toggled off again, refs #255
5b2afb7
@simonw
Fix bug with toggle_url on integer facets
aa827ed
@simonw
_facet selections persist through table form, refs #255
9b37655
@simonw
1,442 format for facet counts, refs #255
0a02517
@simonw
Undid some slightly weird code formatting by 'black'
1c5e386
@simonw
Use escape_sqlite() more consistently
56854e1
@simonw
Foreign key facets are now expanded to labels, refs #255
6293c34
@simonw
Show enabled facets in flexbox columns, refs #255
3b885d3
@simonw
class="suggested-facets"
b5bf3da
@simonw
Hide facet button is now a ✖ - refs #255
436dd11
@simonw
Reliable sort order for facets in Python 3.5, fixing test - refs #255
3ba8a10
@simonw
Clarified relationship between metadata and _facet= facets, updated d…
fe15032 
…ocs - refs @255
@simonw
Typo fix
a70e5f0
@simonw
Added screenshots to facets and full_text_search docs, refs #255
af0e91e
@simonw simonw changed the title Facets (including suggested facets) Facets improvements plus suggested facets May 16, 2018
@simonw simonw merged commit 9959a9e into master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonw