Don't duplicate simple primary keys in the link column #209
Conversation
|
I suspected this would cause some test failures, but I'll wait for opinions before attempting to fix them. |
|
I think this is a good improvement. If you fix the tests I'll merge it. |
When there's a simple (single-column) primary key, it looks weird to duplicate it in the link column. This change removes the second PK column and treats the link column as if it were the PK column from a header/sorting perspective.
f5e6024 to
f4a1ab6
Compare
|
Tests now fixed, honest. The failing test on Travis looks like an intermittent sqlite failure which should resolve itself on a retry... |
8dc813e to
4acde4e
Compare
|
I've added another commit which puts classes a class on each Unfortunately the tests are still failing on 3.6, which is weird. I can't reproduce locally... |
|
I managed to get a better error message out of that test. The server is returning this (but only on Python 3.6, not on Python 3.5 - and only in Travis, not in my local environment):
|
It was failing intermittently in Travis - see #209
It was failing intermittently in Travis - see #209
|
OK, aaf59db should mean that the tests pass when I merge that. |
This ensures that columns with spaces in the name will still generate usable CSS class names. Refs #209
When there's a simple (single-column) primary key, it looks weird to duplicate it in the link column.
This change removes the second PK column and treats the link column as if it were the PK column from a header/sorting perspective.
This might make it a bit more difficult to tell what the link for the row is, I'm not sure yet. I feel like the alternative is to change the link column to just have the text "view" or something, instead of repeating the PK. (I doubt it makes much more sense with compound PKs.)
Bonus change in this PR: fix urlencoding of links in the displayed HTML.
Before:
After:
