Skip to content

Raise 404 on nonexistent table URLs #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Raise 404 on nonexistent table URLs #202

wants to merge 1 commit into from

Conversation

russss
Copy link
Contributor

@russss russss commented Apr 12, 2018 •
edited
Loading

Currently they just 500. Also cleaned the logic up a bit, I hope I didn't miss anything.

This is issue #184.

@russss
Raise 404 on nonexistent table URLs
71bbf4e 
Currently they just 500. Also cleaned the logic up a bit, I hope I
didn't miss anything.
simonw added a commit that referenced this pull request Apr 13, 2018
@simonw
Better mechanism for handling errors; 404s for missing table/database
9f28bbe 
New error mechanism closes #193

404s for missing tables/databesse closes #184

Makes pull request #202 unnecessary.
@simonw
Copy link
Owner

simonw commented Apr 13, 2018

I'm afraid I've just made this obsolete with 9f28bbe

@simonw simonw closed this Apr 13, 2018
@russss
Copy link
Contributor Author

russss commented Apr 13, 2018

I spotted you'd mentioned that in #184 but only after I'd written the patch!

@russss russss deleted the missing-table-error branch April 13, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russss @simonw