Skip to content

Hide Spatialite system tables #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2018
Merged

Hide Spatialite system tables #200

merged 1 commit into from
Apr 12, 2018

Conversation

russss
Copy link
Contributor

@russss russss commented Apr 11, 2018

They were getting on my nerves.

@simonw
Copy link
Owner

simonw commented Apr 11, 2018

We should only do this if we're certain the spatialite module has been loaded. I could imagine someone having a sql_statements_log table of their own without using spatialite for example.

I think the most reliable way to detect spatialite is to run SELECT AddGeometryColumn(1, 2, 3, 4, 5); against a :memory: database and see if it throws an exception - similar to how we detect FTS. We could add this as a detect_spatialite() function in utils.py and call it once on startup.

simonw
simonw reviewed Apr 11, 2018
View reviewed changes
datasette/app.py
@@ -1121,7 +1121,7 @@ def inspect(self):
tables[table]['foreign_keys'] = info

# Mark tables 'hidden' if they relate to FTS virtual tables
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that still makes sense in context - not sure how to make it clearer!

@russss
Copy link
Contributor Author

russss commented Apr 11, 2018

I think the most reliable way to detect spatialite is to run SELECT AddGeometryColumn(1, 2, 3, 4, 5); against a :memory: database and see if it throws an exception

Or just see if there's a geometry_columns table? I think that's quite unlikely to be added by accident (and it's an OGC standard). It also tells you if Spatialite is installed in the database rather than just loaded.

@russss
Hide Spatialite system tables
765b5d6 
They were getting on my nerves.
@russss russss force-pushed the hide-spatialite-tables branch from ab93635 to 765b5d6 Compare April 11, 2018 22:21
@simonw
Copy link
Owner

simonw commented Apr 12, 2018

Nice, thanks very much.

@simonw simonw merged commit d08a133 into simonw:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonw simonw simonw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@russss @simonw