-
-
Notifications
You must be signed in to change notification settings - Fork 771
[SPIKE] Don't truncate query CSVs #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 92.50% // Head: 92.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
==========================================
+ Coverage 92.50% 92.51% +0.01%
==========================================
Files 35 35
Lines 4400 4406 +6
==========================================
+ Hits 4070 4076 +6
Misses 330 330
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
feea811
to
ddcc8bc
Compare
the pattern in this PR i think it would be better to have each of these different query renderers have more direct control for how many rows to fetch, instead of relying on the internals of the generally, users will not want to paginate through tens of thousands of results, but often will want to download a full query as json or as csv. |
Relates to #526
This is a minimal set of changes needed for having query CSVs attempt to download all the rows.
What's good about it is the minimalism.
What's bad about it:
_size
argument to indicate we don't want truncation, which isn't the most obvious thing. Additionally, there are various checks that make sure the "_size" URL parameter is a positive integer, which we are relying on to prevent overloading.📚 Documentation preview 📚: https://datasette--1820.org.readthedocs.build/en/1820/