Skip to content

Conversation

simonw
Copy link
Owner

@simonw simonw commented Aug 23, 2022

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1792 (f61cfb7) into main (fd1086c) will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1792      +/-   ##
==========================================
+ Coverage   91.66%   91.71%   +0.04%     
==========================================
  Files          38       38              
  Lines        4705     4705              
==========================================
+ Hits         4313     4315       +2     
+ Misses        392      390       -2     
Impacted Files Coverage Δ
datasette/database.py 94.13% <0.00%> (+0.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@simonw
Copy link
Owner Author

simonw commented Aug 23, 2022

Really weird: the tests are failing on Python 3.7 only for some reason, in a test that should be completely unrelated to this extension feature.

image

https://github.com/simonw/datasette/runs/7982525580?check_suite_focus=true

@simonw
Copy link
Owner Author

simonw commented Aug 24, 2022

Tests passed. Weird - seems to be an intermittent failure. I'm going to merge this.

@simonw simonw merged commit ba35105 into main Aug 24, 2022
@simonw simonw deleted the test-load-extension branch August 24, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant