-
-
Notifications
You must be signed in to change notification settings - Fork 777
Improve the display of facets information #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 91.55% 91.55%
=======================================
Files 32 32
Lines 3930 3930
=======================================
Hits 3598 3598
Misses 332 332 Continue to review full report at Codecov.
|
@simonw : Did you have the time to take a look at this ? |
@simonw : Could you have a look at this ? I think this really improves readability. |
With just three facets, I like it, but it does take more horizontal space. Would be nice to have a switch somewhere, enabling either original compact option or this proposed more-readable option. Also some control over word wrap (width setting) and facet spacing. |
@mroswell Did you try it with more columns ? The display is flexible and columns get closer as new ones are added. |
@simonw : do you think this could be merged ? |
Courtesy of @lovasoa in simonw/datasette#1159
Hey @lovasoa, I hope you don't mind - I pulled this PR into datasette-ui-extras, a plugin I'm making that collects UI tweaks to Datasette. You can apply it to your own Datasette instance by running |
Added to the 1.0 milestone because: https://news.ycombinator.com/item?id=36932876#36939734
|
This PR changes the display of facets to hopefully make them more readable.