Skip to content

Conversation

lovasoa
Copy link

@lovasoa lovasoa commented Dec 24, 2020

This PR changes the display of facets to hopefully make them more readable.

Before After
image image

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1159 (c820abd) into main (a882d67) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1159   +/-   ##
=======================================
  Coverage   91.55%   91.55%           
=======================================
  Files          32       32           
  Lines        3930     3930           
=======================================
  Hits         3598     3598           
  Misses        332      332           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a882d67...c820abd. Read the comment docs.

@lovasoa
Copy link
Author

lovasoa commented Jan 13, 2021

@simonw : Did you have the time to take a look at this ?

@lovasoa
Copy link
Author

lovasoa commented Feb 1, 2021

@simonw : Could you have a look at this ? I think this really improves readability.

@mroswell
Copy link
Contributor

With just three facets, I like it, but it does take more horizontal space. Would be nice to have a switch somewhere, enabling either original compact option or this proposed more-readable option. Also some control over word wrap (width setting) and facet spacing.

@lovasoa
Copy link
Author

lovasoa commented Mar 23, 2021

@mroswell Did you try it with more columns ? The display is flexible and columns get closer as new ones are added.

@lovasoa
Copy link
Author

lovasoa commented Apr 15, 2022

@simonw : do you think this could be merged ?

cldellow added a commit to cldellow/datasette-ui-extras that referenced this pull request Jan 22, 2023
@cldellow
Copy link
Contributor

Hey @lovasoa, I hope you don't mind - I pulled this PR into datasette-ui-extras, a plugin I'm making that collects UI tweaks to Datasette.

You can apply it to your own Datasette instance by running datasette install datasette-ui-extras

@lovasoa
Copy link
Author

lovasoa commented Jan 22, 2023

great initiative, @cldellow 👍

@simonw, if you want to merge this, that would still be welcome :)

@simonw simonw added this to the Datasette 1.0 milestone Jul 31, 2023
@simonw
Copy link
Owner

simonw commented Jul 31, 2023

Added to the 1.0 milestone because: https://news.ycombinator.com/item?id=36932876#36939734

Hah, wow, it looks like I've been procrastinating on making a decision if I like that or not for three years!

I'll add it to the Datasette 1.0 milestone so it definitely gets my attention before shipping that release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants