Skip to content

Initial add simple prod ready Dockerfile refs #57 #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2017
Merged

Initial add simple prod ready Dockerfile refs #57 #94

merged 1 commit into from
Nov 15, 2017

Conversation

macropin
Copy link
Contributor

Multi-stage build based off official python:3.6-slim

Example usage:

docker run --rm -t -i -p 9000:8001 -v $(pwd)/db:/db datasette datasette serve /db/chinook.db

@simonw
Copy link
Owner

simonw commented Nov 15, 2017

Works for me. I'm going to land this.

Just one thing:

simonw$ docker run --rm -t -i -p 9001:8001 c408e8cfbe40 datasette publish now
 The publish command requires "now" to be installed and configured 
Follow the instructions at https://zeit.co/now#whats-now

Maybe we should have the Docker container install the "now" client? Not sure how much size that would add though. I think it's OK without for the moment.

@simonw simonw merged commit 8675550 into simonw:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macropin @simonw