Skip to content

Support cleaner custom templates for rows and tables, closes #521 #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2019
Merged

Support cleaner custom templates for rows and tables, closes #521 #533

merged 5 commits into from
Jul 3, 2019

Conversation

simonw
Copy link
Owner

@simonw simonw commented Jul 3, 2019 •
edited
Loading

  • Rename _rows_and_columns.html to _table.html
  • Unit test
  • Documentation

@simonw
Copy link
Owner Author

simonw commented Jul 3, 2019 •
edited
Loading

I'd like to rename _rows_and_columns.html to _table.html.

There is at least one project out there using the current filename though: https://github.com/baltimore-sun-data/salaries-datasette/blob/master/templates/_rows_and_columns.html - I shall file an issue there to let them know about the backwards incompatible change.

@simonw simonw force-pushed the better-templates branch from 0b07696 to 7d6b0d6 Compare July 3, 2019 00:52
@simonw simonw merged commit b9ede4c into master Jul 3, 2019
@simonw simonw mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonw