Skip to content

Conversation

simonw
Copy link
Owner

@simonw simonw commented Jun 6, 2019

No description provided.

@simonw
Copy link
Owner Author

simonw commented Nov 11, 2019

Dropping 3.5 compatibility will help here #622

simonw and others added 28 commits November 10, 2019 19:15
Refs #272

This reverts commit 9fdb47c.

Now that ASGI supports raw_path we don't need our own encoding scheme!
Datasette now uses ASGI internally, and no longer depends on Sanic.

It now uses Uvicorn as the underlying HTTP server.

This was thirteen months in the making... for full details see the issue:

#272

And for a full sequence of commits plus commentary, see the pull request:

#518
python tests/fixtures.py needs asgiref or it fails with an error
* Switch to ~= dependencies, closes #532
* Bump click and click-default-group
* imp. is deprecated, use types.ModuleType instead - thanks https://stackoverflow.com/a/32175781
* Upgrade to pytest 5
* extra_template_vars plugin hook

Closes #541

* Workaround for cwd bug

Based on pytest-dev/pytest#1235 (comment)
Now it should be the same size on the homepage as it is on pages with breadcrumbs
simonw and others added 27 commits November 10, 2019 19:15
Following discussion in #601, this PR adds a "Format SQL" button to
read-only SQL (if the SQL actually differs from the formatting result).

It also removes a console error on readonly SQL queries.

Thanks, @rixx!
@simonw
Copy link
Owner Author

simonw commented Nov 11, 2019

Wow! = 379 passed, 4332 warnings in 196.92 seconds = - that's a lot of warnings.

@simonw
Copy link
Owner Author

simonw commented Nov 11, 2019

Closing this so I can do a clean single commit instead.

@simonw simonw closed this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants