Skip to content

Use dist: xenial and python: 3.7 on Travis #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2019
Merged

Use dist: xenial and python: 3.7 on Travis #447

merged 2 commits into from
May 3, 2019

Conversation

simonw
Copy link
Owner

@simonw simonw commented May 3, 2019

No description provided.

@simonw simonw changed the title Try 3.7 on Travis Use dist: xenial and python: 3.7 on Travis May 3, 2019
@simonw
Copy link
Owner Author

simonw commented May 3, 2019

This appears to fix a very weird error we were getting just on Python 3.7-dev: https://travis-ci.org/simonw/datasette/jobs/527858613

That weird error boiled down to count being None:

{
    "columns": ["pk", "distance", "frequency"],
    "name": "units",
    "count": 3,
    "hidden": False,
    "foreign_keys": {"incoming": [], "outgoing": []},
    "fts_table": None,
    "primary_keys": ["pk"],
}
# compared to:
{
    "name": "units",
    "columns": ["pk", "distance", "frequency"],
    "primary_keys": ["pk"],
    "count": None,
    "hidden": False,
    "fts_table": None,
    "foreign_keys": {"incoming": [], "outgoing": []},
}

@simonw simonw merged commit 553314d into master May 3, 2019
@simonw simonw deleted the travis-python-37 branch May 3, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonw