-
-
Notifications
You must be signed in to change notification settings - Fork 772
Refactor facets to a class and new plugin, refs #427 #432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Includes various new partially implemented facet classes, to help exercise the API design.
This will help in implementing __in as a filter, refs #433
Still need to ensure facets from metadata cannot be hidden in the UI
It would be nice to decouple the
Can I pull those needs out of the Facet class somehow? |
I was thinking that it might be handy for datasette to have a request object which wraps the Sanic Request. This could include the datasette-specific querystring decoding and the This would mean that we could expose the request object to plugin hooks without coupling them to Sanic. |
Abandoning this in favour of #445 - which contains the code from this branch but updated to incorporate recent changes in master. |
WIP for #427