Relevant code:

Lines 271 to 295 in afed51b

    
               async def suggest(self): 
        
                   columns = await self.get_columns(self.sql, self.params) 
        
                   suggested_facets = [] 
        
                   already_enabled = [c["config"]["simple"] for c in self.get_configs()] 
        
                   for column in columns: 
        
                       if column in already_enabled: 
        
                           continue 
        
                       # Is every value in this column either null or a JSON array? 
        
                       suggested_facet_sql = """ 
        
                           select distinct json_type({column}) 
        
                           from ({sql}) 
        
                       """.format( 
        
                           column=escape_sqlite(column), sql=self.sql 
        
                       ) 
        
                       try: 
        
                           results = await self.ds.execute( 
        
                               self.database, 
        
                               suggested_facet_sql, 
        
                               self.params, 
        
                               truncate=False, 
        
                               custom_time_limit=self.ds.setting("facet_suggest_time_limit_ms"), 
        
                               log_sql_errors=False, 
        
                           ) 
        
                           types = tuple(r[0] for r in results.rows) 
        
                           if types in (("array",), ("array", None)):

	async def suggest(self):
	columns = await self.get_columns(self.sql, self.params)
	suggested_facets = []
	already_enabled = [c["config"]["simple"] for c in self.get_configs()]
	for column in columns:
	if column in already_enabled:
	continue
	# Is every value in this column either null or a JSON array?
	suggested_facet_sql = """
	select distinct json_type({column})
	from ({sql})
	""".format(
	column=escape_sqlite(column), sql=self.sql
	)
	try:
	results = await self.ds.execute(
	self.database,
	suggested_facet_sql,
	self.params,
	truncate=False,
	custom_time_limit=self.ds.setting("facet_suggest_time_limit_ms"),
	log_sql_errors=False,
	)
	types = tuple(r[0] for r in results.rows)
	if types in (("array",), ("array", None)):

Uh oh!

Suggest for ArrayFacet possibly confused by blank values #1246

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions