Database downloads are served here:

Lines 186 to 192 in d60f163

    
           headers["Transfer-Encoding"] = "chunked" 
        
           return AsgiFileDownload( 
        
               filepath, 
        
               filename=os.path.basename(filepath), 
        
               content_type="application/octet-stream", 
        
               headers=headers, 
        
           )

Here's AsgiFileDownload:

datasette/datasette/utils/asgi.py

Lines 410 to 430 in d60f163

    
           class AsgiFileDownload: 
        
               def __init__( 
        
                   self, 
        
                   filepath, 
        
                   filename=None, 
        
                   content_type="application/octet-stream", 
        
                   headers=None, 
        
               ): 
        
                   self.headers = headers or {} 
        
                   self.filepath = filepath 
        
                   self.filename = filename 
        
                   self.content_type = content_type 
        
               async def asgi_send(self, send): 
        
                   return await asgi_send_file( 
        
                       send, 
        
                       self.filepath, 
        
                       filename=self.filename, 
        
                       content_type=self.content_type, 
        
                       headers=self.headers, 
        
                   )

I can add an etag= parameter to that and populate it with db.hash, if it is populated (which it always should be for immutable databases that can be downloaded).

	headers["Transfer-Encoding"] = "chunked"
	return AsgiFileDownload(
	filepath,
	filename=os.path.basename(filepath),
	content_type="application/octet-stream",
	headers=headers,
	)

	class AsgiFileDownload:
	def __init__(
	self,
	filepath,
	filename=None,
	content_type="application/octet-stream",
	headers=None,
	):
	self.headers = headers or {}
	self.filepath = filepath
	self.filename = filename
	self.content_type = content_type

	async def asgi_send(self, send):
	return await asgi_send_file(
	send,
	self.filepath,
	filename=self.filename,
	content_type=self.content_type,
	headers=self.headers,
	)

Uh oh!

.db downloads should be served with an ETag #1739

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions