cache-control: private is playing havoc with performance

In #6 we disabled all caching for logged in users.

https://github.com/simonw/datasette-auth-github/blob/b3aaa4cc2f9b05a480357727bdce39c57d56fd4c/datasette_auth_github/github_auth.py#L138-L145

It turns out this is causing really nasty performance issues when running with other plugins such as `datasette-vega`! See https://github.com/simonw/datasette/issues/586

	# Rebuild headers to include cache-control: private
	original_headers = event.get("headers") or []
	new_headers = [
	[key, value]
	for key, value in original_headers
	if key.lower() != b"cache-control"
	]
	new_headers.append([b"cache-control", b"private"])

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

cache-control: private is playing havoc with performance #47

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Uh oh!

cache-control: private is playing havoc with performance #47

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions