fix: add missing space before headerClass (#138) #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spike-rabbit
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Thanks a lot for your contribution.
Based on the current code quality around header-cell.component.ts I think it is fine to merge without tests, as there is currently not even a test file set up.
@LeoVie please note, that we are currently doing some larger clean ups, like introducing types everywhere. So it may takes a while till this is actually released.
|
|
|
@LeoVie can you please sign the CLA so that I can merge your PR |
|
Thx a lot again for contributing. 🚀 Hope we will ship this soon. |
|
Thank you too :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
#138
What is the new behavior?
This PR adds the missing space, as described in #138
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
If you are very, very strict, this is a breaking change for the few people, that used a string returning function for
headerClassand that did not realize, that their class is not getting applied.Other information: