Skip to content

Add runtime warnings for the deprecated extensions used in Siddhi Apps #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 30, 2021
Merged

Add runtime warnings for the deprecated extensions used in Siddhi Apps #1734

merged 4 commits into from
Aug 30, 2021

Conversation

grainier
Copy link
Contributor

@grainier grainier commented Jul 9, 2021

Purpose

$title. Currently deprecated = true is only used with doc gen. With this PR it will also give a runtime warning for such extensions.

Samples

@Extension(
        name = "xxxxx",
        deprecated = true,
        namespace = "xxxxx",
        description = "xxxxx",
        examples = {
                @Example(
                        xxxxx
                )
        }
)

Goals

n/a

Approach

n/a

Release note

  • deprecated extensions will give a warning at the runtime.

Documentation

n/a

Automation tests

  • Unit tests added

Security checks

Related PRs

n/a

Test environment

n/a

@AnuGayan AnuGayan merged commit d39606e into siddhi-io:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuGayan AnuGayan AnuGayan approved these changes

@tishan89 tishan89 Awaiting requested review from tishan89

@suhothayan suhothayan Awaiting requested review from suhothayan

@mohanvive mohanvive Awaiting requested review from mohanvive

@ramindu90 ramindu90 Awaiting requested review from ramindu90

@pcnfernando pcnfernando Awaiting requested review from pcnfernando

Assignees
No one assigned
Labels
type/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grainier @AnuGayan