pkg/signature: expose Algorithm Details information #2001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Schirone <riccardo.schirone@trailofbits.com>
0c6f95f to
fbba040
Compare
Merged
Signed-off-by: Riccardo Schirone <riccardo.schirone@trailofbits.com>
Signed-off-by: Riccardo Schirone <riccardo.schirone@trailofbits.com>
haydentherapper
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As we make Sigstore ecosystem more crypto agile, we need various parts to know what they are dealing with. For example, one may want to get information about the hash function to be used with a public key of a given type. Clients may want to enforce some signing algorithms and need to know which hash/options to use for a particular key or for a specific signing algorithm.
For now, I see this being used in fulcio to associate a hash function to a given public key.
Release Note
AlgorithmDetailsinterface and theGetAlgorithmDetailsfunction to get information about an algorithm given aPublicKeyDetailsvalue (defined in protobuf-specs).Documentation
None