Skip to content

Conversation

bobcallaway
Copy link
Member

this is unused; witnessing will be added in rekor v2

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner July 18, 2025 20:12
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove redis from docker-compose - #2487

Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.00%. Comparing base (488eb97) to head (b4cf1ae).
⚠️ Report is 458 commits behind head on main.

Files with missing lines Patch % Lines
...g/generated/client/tlog/get_log_info_parameters.go 0.00% 1 Missing ⚠️
...restapi/operations/tlog/get_log_info_parameters.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2537       +/-   ##
===========================================
- Coverage   66.46%   25.00%   -41.46%     
===========================================
  Files          92      189       +97     
  Lines        9258    24409    +15151     
===========================================
- Hits         6153     6104       -49     
- Misses       2359    17541    +15182     
- Partials      746      764       +18     
Flag Coverage Δ
e2etests 46.85% <ø> (-0.71%) ⬇️
unittests 16.23% <0.00%> (-31.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haydentherapper
Copy link
Contributor

You'll need to update

grep -E "(rekor[-_]mysql|rekor[-_]redis|rekor[-_]rekor-server|rekor[-_]gcp-pubsub-emulator)" | \
and
grep -E "(rekor[-_]mysql|rekor[-_]redis|rekor[-_]rekor-server|rekor[-_]trillian)" | \
since Redis is no longer spun up. Also remove enable_stable_checkpoint from the Compose config

Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Signed-off-by: Bob Callaway <bcallaway@google.com>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@bobcallaway bobcallaway merged commit 6b4e260 into sigstore:main Jul 28, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants