backoff pubsub emulator to last-known good #2535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
cpanato
previously approved these changes
Jul 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
===========================================
- Coverage 66.46% 25.14% -41.32%
===========================================
Files 92 191 +99
Lines 9258 24789 +15531
===========================================
+ Hits 6153 6234 +81
- Misses 2359 17788 +15429
- Partials 746 767 +21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, but there’s some issue with the harness test suite, I’m looking into it. I added dockerfiles for the trillian services recently, but I’m not immediately seeing the issue. |
Signed-off-by: Bob Callaway <bcallaway@google.com>
haydentherapper
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there's a bug in the pubsub emulator due to a dependency mismatch; the fix probably won't be out until next week so backing this off to unblock other PRs