emit unpopulated values when marshalling TLE #2438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bcallaway@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
===========================================
- Coverage 66.46% 25.25% -41.21%
===========================================
Files 92 192 +100
Lines 9258 24874 +15616
===========================================
+ Hits 6153 6283 +130
- Misses 2359 17815 +15456
- Partials 746 776 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haydentherapper
approved these changes
Apr 11, 2025
| Checkpoint: swag.String("checkpoint"), | ||
| Hashes: []string{}, | ||
| LogIndex: swag.Int64(0), | ||
| RootHash: swag.String("abcdefaa"), |
There was a problem hiding this comment.
I'm trying to find the commit now, but are we handling an empty log root hash by providing the default sha256([]byte{})?
There was a problem hiding this comment.
Ah we return #1311, that's fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if log index is 0 (or there are no hashes in an inclusion proof - which is possible only for the first entry in a log), we're not marshalling values to disk. The default values are implicit but I think being explicit here is better than omitting the value completely