Fix release-signing-artifacts behavior and docs
#103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
|
Looks good to me. |
jku
approved these changes
Jan 10, 2024
| @@ -370,6 +370,7 @@ Example: | |||
|
|
|||
| The `release-signing-artifacts` setting controls whether or not `sigstore-python` | |||
| uploads signing artifacts to the release publishing event that triggered this run. | |||
| This setting has no effect on non-`release` events. | |||
There was a problem hiding this comment.
I also did not realise the intended usage was to use the "release" event so this is useful (I've always made my release pipelines triggered from release git tags).
There was a problem hiding this comment.
Same here, which is why I tripped over it.
There was a problem hiding this comment.
Yep, this was entirely an oversight on our side -- the actual release uploading step only runs when the event name matches; we just missed the corresponding check on this side 🙂
|
Thanks for fixing so quickly folks, this is what makes open source so great 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two parts:
release-signing-artifactsif theGITHUB_EVENT_NAMEis notrelease, since it can only work in the context of releases and their associated artifacts.release-signing-artifactsnow makes this clear.CC @stevenh for review as well, as the original reporter 🙂
Closes #99.