Use Tink key APIs in tinkca.KeyHandleToSigner
#2024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tink v2.3.0 [1] added the ability to extract individual keys from a Tink `keyset.Handle` as key objects. This PR modifies `KeyHandleToSigner` to use such APIs, significantly simplifying it. Note that there is no need to validate keys because they are validated when the `keyset.Handle` is created [2],[3],[4]. Also refactoring `signer_test.go` and adding a test case for an invalid key type. [1] https://github.com/tink-crypto/tink-go/releases/tag/v2.3.0 [2] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ecdsa/key.go#L380 [3] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ecdsa/key.go#L167 [4] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ed25519/key.go#L206-L209 Signed-off-by: Moreno Ambrosin <ambrosin@google.com>
|
This is just #1981 rebased against main, and fixing a lint error. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
===========================================
- Coverage 57.93% 43.75% -14.19%
===========================================
Files 50 73 +23
Lines 3119 5696 +2577
===========================================
+ Hits 1807 2492 +685
- Misses 1154 2983 +1829
- Partials 158 221 +63 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
haydentherapper
added a commit
to haydentherapper/sigstore
that referenced
this pull request
Apr 23, 2025
From sigstore/fulcio#2024. Will update Fulcio and other Sigstore repos to use this shared implementation. Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
cpanato
approved these changes
Apr 24, 2025
bobcallaway
approved these changes
Apr 24, 2025
| encodingName := ecdsapb.EcdsaSignatureEncoding_name[int32(params.GetEncoding())] | ||
| return hashName, curveName, encodingName | ||
| } | ||
| curve, err := curveFromTinkECDSACurveType(ecdsaPublicKey.Parameters().(*tinkecdsa.Parameters).CurveType()) |
There was a problem hiding this comment.
not sure if a defensive check for ecdsaPublicKey.Parameters() being nil is worth it here
|
Going to hold on this and replace this with the impl in sigstore/sigstore |
haydentherapper
added a commit
to sigstore/sigstore
that referenced
this pull request
Apr 24, 2025
* Update to use Tink v2.3.0 API From sigstore/fulcio#2024. Will update Fulcio and other Sigstore repos to use this shared implementation. Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com> * Fix linting errors Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com> --------- Signed-off-by: Hayden B <8418760+haydentherapper@users.noreply.github.com> Co-authored-by: Hayden B <8418760+haydentherapper@users.noreply.github.com>
|
The signer in this PR has been moved to sigstore/sigstore, #2026 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tink v2.3.0 [1] added the ability to extract individual keys from a Tink
keyset.Handleas key objects. This PR modifiesKeyHandleToSignerto use such APIs, significantly simplifying it. Note that there is no need to validate keys because they are validated when thekeyset.Handleis created [2],[3],[4].Also refactoring
signer_test.goand adding a test case for an invalid key type.[1] https://github.com/tink-crypto/tink-go/releases/tag/v2.3.0
[2] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ecdsa/key.go#L380
[3] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ecdsa/key.go#L167
[4] https://github.com/tink-crypto/tink-go/blob/v2.3.0/signature/ed25519/key.go#L206-L209
Summary
Release Note
Documentation