Use Tink key APIs in tinkca.KeyHandleToSigner
#1981
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
===========================================
- Coverage 57.93% 43.63% -14.31%
===========================================
Files 50 73 +23
Lines 3119 5693 +2574
===========================================
+ Hits 1807 2484 +677
- Misses 1154 2985 +1831
- Partials 158 224 +66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
LGTM, I'd like @haydentherapper to take a look |
|
Thank you so much for updating this! Sorry about closing the PR, I tried to update the PR with an additional commit and something went wrong. #2024 for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tink v2.3.0 added APIs to extract individual keys from a Keyset. This PR is simply a refactoring of
KeyHandleToSignerthat simplifies it to leverage such APIs, and removes some redundant key validations.Release Note
NONE
Documentation
NONE