Add differential memory usage tracking #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Oct 28, 2024
michaelsproul
commented
Mar 3, 2025
|
|
||
| pub trait MemorySize { | ||
| /// The memory address of this item. | ||
| fn self_pointer(&self) -> usize; |
There was a problem hiding this comment.
We found a bug on the MemorySize impl for BeaconState where we were returning the &BeaconState from self_pointer. This meant that mutating a beacon state without cloning it would cause the memory tracker to skip over the state when provided a second time, because it thought the pointer had already been seen.
We should probably make sure that pointers returned by self_pointer are immutable, i.e. the address uniquely determines the contents at that address.
There was a problem hiding this comment.
Tried using Arc, but ran into issues with test because of wrapping impl List in Arc. Will look into it as I keep working on Lighthouse#7449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a much-thought-about feature to track the differential size of multiple data structures stored using structural sharing!