Skip to content

Ensure light_client/updates endpoint returns spec compliant SSZ data #7230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 11, 2025
Merged

Ensure light_client/updates endpoint returns spec compliant SSZ data #7230

merged 7 commits into from
Apr 11, 2025

Conversation

eserilev
Copy link
Member

Issue Addressed

Closes #7167

Proposed Changes

  • Ensure the fork digest is generated from ther light client updates attested header and not the signature slot
  • Ensure the format of the SSZ response is spec compliant

@eserilev eserilev added bug Something isn't working HTTP-API light-client labels Mar 31, 2025
@eserilev eserilev changed the base branch from stable to release-v7.0.0 March 31, 2025 16:17
@eserilev eserilev added the work-in-progress PR is a work-in-progress label Mar 31, 2025
@michaelsproul michaelsproul added the v7.0.0 New release c. Q1 2025 label Apr 9, 2025
@michaelsproul michaelsproul mentioned this pull request Apr 9, 2025
Merged
@eserilev eserilev changed the title [WIP] Ensure light_client/updates endpoint returns spec compliant SSZ data Ensure light_client/updates endpoint returns spec compliant SSZ data Apr 9, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Apr 9, 2025
michaelsproul
michaelsproul requested changes Apr 10, 2025
View reviewed changes
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Apr 10, 2025
@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Apr 10, 2025
@macladson macladson added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 11, 2025
mergify bot added a commit that referenced this pull request Apr 11, 2025
@mergify
Merge of #7230
6dbf6e4
@mergify mergify bot mentioned this pull request Apr 11, 2025
Closed
10 tasks
@mergify mergify bot merged commit ef8ec35 into sigp:release-v7.0.0 Apr 11, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@macladson macladson macladson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working HTTP-API light-client ready-for-merge This PR is ready to merge. v7.0.0 New release c. Q1 2025
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Light Client Update SSZ Responses based on Attested Header Slot and not Signature Slot
3 participants
@eserilev @michaelsproul @macladson