Fix xdelta3 output buffer issue #7174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My suspicion is that this was triggered on Holesky at slot 3670016, as that is around when the operator started seeing the errors. That slot is a multiple of I don't understand why this diff would be so large though, as there were already 1.66M validators on Holesky at this time (https://light-holesky.beaconcha.in/epoch/65536). It might have been a bunch of the churn generated by the non-finality incident, but we would need to see that diff to understand more. I'm working on syncing a Holesky archive node so we can have a closer look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Attempt to fix an issue whereby
xdelta3would try to guess the size of the output buffer during diff application. If the guess was incorrect, an error would be returned and the diff application would not be re-attempted.This branch uses an exponential doubling of the output buffer in the case of an insufficient space error, meaning that diffs should never fail due to insufficient space.
We are waiting on confirmation from a node operator on Holesky that this actually fixes the issue. We will also sync a Holesky archive node on our infra to try to repro the issue.
Additional Info
Requires this upstream PR: