Skip to content

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Mar 11, 2025

Proposed Changes

Delete duplicate sync tolerance epoch config in the HTTP API which is unused.

We introduced the sync-tolerance-epoch flag in this PR:

Then refined it in this PR:

Somewhere in the merge of release-v7.0.0 into unstable, the config from the original PR which had been deleted came back. I think I resolved these conflicts, so my bad.

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality labels Mar 11, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jimmygchen jimmygchen removed the ready-for-review The code is ready for review label Mar 11, 2025
@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Mar 11, 2025
@mergify mergify bot merged commit 1a08e6f into sigp:unstable Mar 11, 2025
31 checks passed
@michaelsproul michaelsproul deleted the rm-dup-sync-tolerance branch March 11, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants