Ensure finalized block is the correct fork variant when constructing light client updates #7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
approved these changes
Mar 7, 2025
michaelsproul
requested changes
Mar 11, 2025
dapplion
approved these changes
Mar 12, 2025
michaelsproul
approved these changes
Mar 17, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where, after a fork, we construct invalid light client updates for at least two epochs (until we reach finality). This is because the beacon states finalized checkpoint lies on the previous fork for at least the first two epochs. We will try to use that finalized checkpoint to construct a finalized light client header for the current fork variant instead of the previous fork variant.
This PR adds a check that the
finalized_header.fork_name == attested_header.fork_name. If the check fails, we construct a "default" finalized light client header, one whose values are all set to0x0.Note that this also resolves an issue that we thought was related to light client data construction requiring fork epochs to be divisible by 256. I've tested on kurtosis with
electra_epoch = 1and the node was able to construct light client updates without any problems.I've also re-introduced verifying light client updates in
basic-sim