Prevent writing to state cache when migrating the database #7067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver when we write to the cache
| @@ -821,7 +821,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> { | |||
| .get_blinded_block(&block_root)? | |||
| .ok_or(Error::MissingBeaconBlock(block_root))?; | |||
| let state = self | |||
| .get_state(&block.state_root(), Some(block.slot()))? | |||
| .get_state(&block.state_root(), Some(block.slot()), true)? | |||
There was a problem hiding this comment.
Only used in tests so doesn't matter
| .get_state( | ||
| &genesis_block.state_root(), | ||
| Some(genesis_block.slot()), | ||
| true, |
There was a problem hiding this comment.
This is ok as we almost always have the genesis state in the freezer
- add state-cache-headroom flag to control pruning - prune old epoch boundary states ahead of mid-epoch states - never prune head block's state - avoid caching ancestor states unless they are on an epoch boundary
michaelsproul
approved these changes
Mar 4, 2025
14 tasks
|
I'll PR this to |
michaelsproul
added a commit
to michaelsproul/lighthouse
that referenced
this pull request
Mar 10, 2025
* add an update_cache flag to get_state to have more granular control over when we write to the cache * State cache tweaks - add state-cache-headroom flag to control pruning - prune old epoch boundary states ahead of mid-epoch states - never prune head block's state - avoid caching ancestor states unless they are on an epoch boundary --------- Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Merged
mergify bot
pushed a commit
that referenced
this pull request
Mar 18, 2025
Backport of: - #7067 For: - #7039 - Prevent writing to state cache when migrating the database - Add `state-cache-headroom` flag to control pruning - Prune old epoch boundary states ahead of mid-epoch states - Never prune head block's state - Avoid caching ancestor states unless they are on an epoch boundary - Log when states enter/exit the cache Co-authored-by: Eitan Seri-Levi <eserilev@ucsc.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new flag
update_cachetoget_state. When set to false, prevent writing fetched state to the cache