Change state cache size default to 32 #7055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Feb 28, 2025
14 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Cherry-picking #7055 from `holesky-rescue` branch to the clean `release-v7.0.0` branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Part of #7053 to mitigate OOM issues on holesky.
Each epoch boundary state diffs are 180MB+, 128 (current default) of them would add up to 20GB in state cache.
This PR changes the default to 32 (
180 * 32 ~= 6GBwhich is not too bad).Note: we're still getting too many state cache misses from
*ByRange- this is addressed in #7058