Custody backfill sync #7625
Closed
Custody backfill sync #7625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…ta-column-cgc-backfill-sync-initial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#7603
Proposed Changes
Introduce a new custody backfill syncing service. An mpsc channel is introduced so that lighthouse services can communicate with sync to trigger custody backfill when CGC changes.
Additional Notes
We could try fitting in custody backfill functionality into our current backfill service, but I think this adds complexity to the backfill service and could introduce bugs/edge cases we really don't want to deal with. It feels like a separate custody backfill service is easier to maintain and allows for a nice separation of concerns. Happy to be proven otherwise