Fulu EF tests v1.6.0-alpha.0 #7540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ethDreamer, I'll pick it up from here! |
|
There's something weird going on when I test locally where some Capella and Deneb test files are detected as unused. Not sure what is going on there, and I need to run now.
Ohhh, this might be a change in the test format? And we're not reading those files? |
jimmygchen
reviewed
Jun 4, 2025
| match T::tree_hash_type() { | ||
| TreeHashType::Basic => { | ||
| let mut hasher = | ||
| MerkleHasher::with_leaves(max_len.div_ceil(T::tree_hash_packing_factor())); |
There was a problem hiding this comment.
I guess this is covered by the spec tests in LH - but we should add a unit test if we move this into the ssz library.
There was a problem hiding this comment.
Yeah agreed. I'll work on a PR for that
jimmygchen
reviewed
Jun 4, 2025
jimmygchen
reviewed
Jun 4, 2025
jimmygchen
approved these changes
Jun 4, 2025
|
Looks great, really nice work @ethDreamer @michaelsproul 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Update to EF tests v1.6.0-alpha.0