Skip to content

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Feb 7, 2025

Issue Addressed

This PR adds an implementation to get fork_version and fork_epoch given a ForkName. I didn't realize that this is already implemented in the ChainSpec sorry

Proposed Changes

Remove duplicated fork_epoch and fork_version implementation

@dapplion dapplion added the ready-for-review The code is ready for review label Feb 7, 2025
@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 7, 2025
mergify bot added a commit that referenced this pull request Feb 7, 2025
@mergify mergify bot merged commit e3c7218 into sigp:unstable Feb 8, 2025
31 checks passed
@dapplion dapplion deleted the duplicate-fork-version-impl branch February 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants