Skip to content

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Feb 7, 2025

Issue Addressed

A temporary workaround for the failing execution tests for geth.

https://github.com/sigp/lighthouse/actions/runs/13192297954

The test is broken due to the following breaking changes in geth that requires updating our tests:

  1. removal of personal namespace in v1.14.12: See #30704
  2. removal of totalDifficulty field from RPC in v1.14.11. See #30386.

Using an older version for now ( 1.14.10) as we need to get things merged for the upcoming release.

Will create a separate issue to fix this.

@jimmygchen
Copy link
Member Author

Issue raised to fix this: #6937

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025 labels Feb 7, 2025
@mergify mergify bot merged commit 9c45a0e into sigp:unstable Feb 7, 2025
31 checks passed
@jimmygchen jimmygchen deleted the fix-ee-tests branch February 7, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants