Add more range sync tests #6872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
2327ccc to
7c39d17
Compare
7 tasks
jimmygchen
reviewed
Feb 7, 2025
|
|
||
| // Unikely that the single peer we added has enough columns for us. Find a way to make this test | ||
| // deterministic. | ||
| r.add_random_peer_not_supernode(remote_info.clone()); |
There was a problem hiding this comment.
We could just thread a fixed seed rng to these functions when generating peers?
StdRng::seed_from_u64(0xDEADBEEF0BAD5EEDu64)
For all peerdas tests we should probably make them deterministric, otherwise we could end up with flaky tests.
There was a problem hiding this comment.
Made tests deterministic 2021abc
Switched to ChaCha20 rng as Xor does not implement CryptoRng, required by the enr crate
jimmygchen
requested changes
Feb 7, 2025
|
This pull request has merge conflicts. Could you please resolve them @dapplion? 🙏 |
|
Ready for merge once release process is done. |
6 tasks
pawanjay176
pushed a commit
to pawanjay176/lighthouse
that referenced
this pull request
Feb 21, 2025
Currently we have very poor coverage of range sync with unit tests. With the event driven test framework we could cover much more ground and be confident when modifying the code. Add two basic cases: - Happy path, complete a finalized sync for 2 epochs - Post-PeerDAS case where we start without enough custody peers and later we find enough⚠️ If you have ideas for more test cases, please let me know! I'll write them
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Mar 5, 2025
Currently we have very poor coverage of range sync with unit tests. With the event driven test framework we could cover much more ground and be confident when modifying the code. Add two basic cases: - Happy path, complete a finalized sync for 2 epochs - Post-PeerDAS case where we start without enough custody peers and later we find enough⚠️ If you have ideas for more test cases, please let me know! I'll write them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Currently we have very poor coverage of range sync with unit tests. With the event driven test framework we could cover much more ground and be confident when modifying the code.
Proposed Changes
Add two basic cases: