Skip to content

Conversation

chong-he
Copy link
Member

@chong-he chong-he commented Jan 7, 2025

There seems to be some Cargo.toml not sorted alphabetically, after discussion with @macladson , it could be due to a bug in cargo sort . This PR sorts the Cargo.toml files that are not detected by cargo sort for some reasons.

@chong-he chong-he added the ready-for-review The code is ready for review label Jan 7, 2025
@macladson
Copy link
Member

macladson commented Jan 9, 2025

Hey @chong-he, I discovered that the source of the issue was that certain crates were not added to the Lighthouse workspace. I have fixed this in my PR and also run cargo sort --workspace to ensure it is working.

@chong-he
Copy link
Member Author

chong-he commented Jan 9, 2025

Closing in favour of #6774

@chong-he chong-he closed this Jan 9, 2025
@chong-he chong-he deleted the sort-deps branch February 13, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review The code is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants