Set Java Version to 21 (required since Web3Signer 24.12.0). #6674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 10, 2024
|
I'm going to cherry-pick your commit into this PR: Then merge that to |
|
how did I miss that :-( |
|
bumped, pulled, and cycled on all runners. we can rollback this additional step now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Latest Web3Signer release 24.12.0 requires Java 21 runtime.
Our GitHub runners uses Java 19, hence Web3Signer fails to start in our release tests. This PR install Java 21 using the
setup-javaaction. We could also include this in our runner image to avoid downloading during CI runs.