Track beacon processor import result metrics #6541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92e801b to
dc81bbd
Compare
jimmygchen
reviewed
Dec 13, 2024
beacon_node/network/src/metrics.rs
Outdated
| LazyLock::new(|| { | ||
| try_create_int_counter_vec( | ||
| "beacon_processor_import_errors_total", | ||
| "Total number of block components verified", |
There was a problem hiding this comment.
This should be Total number of block components that was not verified
jimmygchen
requested changes
Dec 13, 2024
dc81bbd to
77e8e8b
Compare
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c92c07f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Our current metrics to track the result of block imports are incomplete. A block import can be triggered by any block component, both from gossip and RPC. We should metric the
AvailabilityProcessingStatusof block, blob, and custody column import to count all possible import events.Also, I would like to track all errors that can occur during import. For example
BlockError::DuplicateFullyImported, which show the efficiency of sync.Proposed Changes
Track the return of all
process_*functions with the same helperregister_process_result_metrics. Track the resultFullyImported/MissingComponents/Errorlabeled by block component and provenance.Additional Info
This PR has no breaking changes w.r.t. current metrics. However, it fixes the following metric:
beacon_processor_rpc_block_imported_total: This metric is incorrect. Blocks with blobs synced by lookup sync are never tracked, as the block is always imported first and blobs second.