Skip to content

Conversation

realbigsean
Copy link
Member

@realbigsean realbigsean commented Mar 26, 2024

Issue Addressed

  • add logs
  • tighten up lookup de-duplication logic
  • an alternative fix to: Fix unexpected UnrequestedBlobId and ExtraBlocksReturned errors due to race conditions. #5477
    • the core issue in the bug there is that we update requested_ids while blobs are still downloading if we download the RPC block in between blobs of the stream. this becomes and issue because requested_ids is updated with any blobs that come via gossip.
    • proposed solution here is to only update the blobs if the request state is AwaitingDownload which means it has been either completed or not yet started

@realbigsean realbigsean added ready-for-review The code is ready for review bug Something isn't working deneb v5.2.0 Q2 2024 labels Mar 26, 2024
@realbigsean
Copy link
Member Author

closing in favor of #5488

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deneb ready-for-review The code is ready for review v5.2.0 Q2 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant