Optimise status processing #5481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Mar 26, 2024
| } else { | ||
| // Peer's finality is older than ours, but newer than our split point, making a | ||
| // block root check infeasible. This case shouldn't happen particularly often so | ||
| // we give the peer the benefit of the doubt and let them connect to us. |
There was a problem hiding this comment.
AFAIU this can happen if pruning is lagging in our end? If finality is recent you can do a cheap check against the head state, else default to None
There was a problem hiding this comment.
Yeah, we can even choose to lag the split point using --epochs-per-migration
I'll add another case for if finality is recent
dapplion
approved these changes
Apr 9, 2024
|
Fixed already in: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Avoid expensive
block_root_at_slotcall in status processing. This proved to be very time consuming on networks without finality, like Goerli.