Skip to content

[Merged by Bors] - Remove Redundant Trait Bound #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Remove Redundant Trait Bound #4169

wants to merge 1 commit into from

Conversation

ethDreamer
Copy link
Member

I realized this is redundant while reasoning about how the store is implemented given the definition of ItemStore

pub trait ItemStore<E: EthSpec>: KeyValueStore<E> + Sync + Send + Sized + 'static {
    ...
}

@ethDreamer ethDreamer added ready-for-review The code is ready for review code-quality labels Apr 5, 2023
jimmygchen
jimmygchen approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

paulhauner
paulhauner approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It compiles, so LGTM.

@paulhauner paulhauner added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 11, 2023
@michaelsproul
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 12, 2023
@ethDreamer
Remove Redundant Trait Bound (#4169)
00cf5fc 
I realized this is redundant while reasoning about how the `store` is implemented given the [definition of `ItemStore`](https://github.com/sigp/lighthouse/blob/v4.0.1/beacon_node/store/src/lib.rs#L107)
```rust
pub trait ItemStore<E: EthSpec>: KeyValueStore<E> + Sync + Send + Sized + 'static {
    ...
}
```
@bors
Copy link

bors bot commented Apr 12, 2023

Pull request successfully merged into unstable.

Build succeeded:

@bors bors bot changed the title Remove Redundant Trait Bound [Merged by Bors] - Remove Redundant Trait Bound Apr 12, 2023
@bors bors bot closed this Apr 12, 2023
ghost pushed a commit to oone-world/lighthouse that referenced this pull request Jul 13, 2023
@ethDreamer
Remove Redundant Trait Bound (sigp#4169)
3e02c83 
I realized this is redundant while reasoning about how the `store` is implemented given the [definition of `ItemStore`](https://github.com/sigp/lighthouse/blob/v4.0.1/beacon_node/store/src/lib.rs#L107)
```rust
pub trait ItemStore<E: EthSpec>: KeyValueStore<E> + Sync + Send + Sized + 'static {
    ...
}
```
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this pull request Jan 6, 2024
@ethDreamer @Woodpile37
Remove Redundant Trait Bound (sigp#4169)
359d04d 
I realized this is redundant while reasoning about how the `store` is implemented given the [definition of `ItemStore`](https://github.com/sigp/lighthouse/blob/v4.0.1/beacon_node/store/src/lib.rs#L107)
```rust
pub trait ItemStore<E: EthSpec>: KeyValueStore<E> + Sync + Send + Sized + 'static {
    ...
}
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

@paulhauner paulhauner paulhauner approved these changes

+1 more reviewer

@ZRDK ZRDK ZRDK approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
code-quality ready-for-merge This PR is ready to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ethDreamer @michaelsproul @jimmygchen @paulhauner @ZRDK