Skip to content

Align proposer re-orgs with latest spec #4887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Align proposer re-orgs with latest spec #4887

wants to merge 1 commit into from

Conversation

michaelsproul
Copy link
Member

Proposed Changes

Update the proposer re-orgs feature for the latest spec, and add new spec test runners.

Additional Info

  • Add REORG_PARENT_WEIGHT_THRESHOLD.
  • Rename REORG_WEIGHT_THRESHOLD to REORG_HEAD_WEIGHT_THRESHOLD.
  • Add reorg parameters to ChainSpec/Config. We should use these as defaults while continuing to allow overrides via the CLI.

@michaelsproul michaelsproul added spec_change A change related to the Eth2 spec work-in-progress PR is a work-in-progress consensus An issue/PR that touches consensus code, such as state_processing or block verification. labels Oct 27, 2023
@michaelsproul michaelsproul mentioned this pull request Oct 27, 2023
Merged
@michaelsproul michaelsproul mentioned this pull request Nov 28, 2023
Merged
@michaelsproul
Copy link
Member Author

Blocking this on #4900 which also updates the re-org tests

@dapplion
Copy link
Collaborator

@dapplion dapplion removed the blocked label Jan 19, 2024
@dapplion dapplion mentioned this pull request Jan 19, 2024
Merged
@michaelsproul michaelsproul mentioned this pull request Feb 14, 2024
Merged
@michaelsproul michaelsproul mentioned this pull request Mar 18, 2024
Merged
5 tasks
@michaelsproul
Copy link
Member Author

Closing in favour of:

Thanks Eitan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consensus An issue/PR that touches consensus code, such as state_processing or block verification. spec_change A change related to the Eth2 spec work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @dapplion